----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64622/#review193838 -----------------------------------------------------------
Ship it! Good to see the shade-plugin gone! - Madhan Neethiraj On Dec. 14, 2017, 7:59 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64622/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2017, 7:59 p.m.) > > > Review request for ranger, Madhan Neethiraj, Sailaja Polavarapu, and > Velmurugan Periasamy. > > > Bugs: RANGER-1931 > https://issues.apache.org/jira/browse/RANGER-1931 > > > Repository: ranger > > > Description > ------- > > Ranger does not need to use any shaded JARs. So, Ranger build scripts (POMs) > should not use maven-shade-plugin. > > There are two places where shaded jars are used; hdfs-agent - because it > shaded javassist.jar, and ldapconfigchecktool - because it used an uber-jar > to build a self-contained, executable jar for config-check tool. > Modifications are made to these to avoid using shaded libraries. > > > Diffs > ----- > > hdfs-agent/pom.xml 7aec881 > > hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/agent/AuthCodeInjectionJavaAgent.java > 065c8a5 > > hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/agent/HadoopAuthClassTransformer.java > 7356cae > pom.xml 3086a1e > src/main/assembly/usersync.xml 8d21dd3 > ugsync/ldapconfigchecktool/ldapconfigcheck/pom.xml 20960cc > > > Diff: https://reviews.apache.org/r/64622/diff/1/ > > > Testing > ------- > > Tested locally. > > > Thanks, > > Abhay Kulkarni > >
