> On 十二月 18, 2017, 4:20 p.m., Colm O hEigeartaigh wrote: > > Looks pretty good to me. Could you remove the whitespace errors from the > > patch?
Ok. I had fixed it. Please get it from https://reviews.apache.org/r/64634/diff/4/. Thanks. - pengjianhua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64634/#review194076 ----------------------------------------------------------- On 十二月 19, 2017, 9:16 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64634/ > ----------------------------------------------------------- > > (Updated 十二月 19, 2017, 9:16 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1929 > https://issues.apache.org/jira/browse/RANGER-1929 > > > Repository: ranger > > > Description > ------- > > Currently we can only edit the policy without previewing the policy. We must > use editing funtion of policy when only need to query the detail for policy. > So we should supply the function of the query detail for policy. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > b8de5c3b > > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js > PRE-CREATION > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js > PRE-CREATION > > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js > 09e2e166 > security-admin/src/main/webapp/styles/xa.css 22eedf64 > > security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html > PRE-CREATION > > security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html > PRE-CREATION > > > Diff: https://reviews.apache.org/r/64634/diff/4/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
