----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65525/#review197081 -----------------------------------------------------------
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js Lines 1008 (patched) <https://reviews.apache.org/r/65525/#comment277187> It would be better, if this 'hive' specific code could be separated to, not to grow this already huge javascript file. I imagine, calling something: var formatter = XAEnums.AuditFormatter[model.get('serviceType')]; var result; if (formatter) { result = formatter(model); } if (!result) { result = /// the default string concating code } return result; And in XAEnums.AuditFormatter this could be a map of functions. AuditFormatter = { 'hive' : function(model) { ... } } security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js Lines 1633 (patched) <https://reviews.apache.org/r/65525/#comment277188> The same trick could be applied. - Zsombor Gegesy On Feb. 6, 2018, 6:46 a.m., Nikhil P wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65525/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2018, 6:46 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan > Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1963 > https://issues.apache.org/jira/browse/RANGER-1963 > > > Repository: ranger > > > Description > ------- > > Hive Access audits in ranger(Access Audit Tab) should show the actual query > associated with the hive access event for a particular column or table or > database. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/service/XAccessAuditService.java > 5d03fb2 > > security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java > a3c693e > security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 939d7e6 > security-admin/src/main/webapp/scripts/utils/XAUtils.js 8fa7fca > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 0e864b6 > security-admin/src/main/webapp/styles/xa.css ee13655 > security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html > bee65db > > > Diff: https://reviews.apache.org/r/65525/diff/1/ > > > Testing > ------- > > 1.Verified various hive queries gets displayed on UI. > 2.checked grant/revoke queries gets reflected correctly on UI. > 3.verified if configurable hive query visibility property works properly. > > > Thanks, > > Nikhil P > >
