----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65739/#review198311 -----------------------------------------------------------
security-admin/db/mysql/patches/030-create-schema-for-usersync-audit-info.sql Lines 1 (patched) <https://reviews.apache.org/r/65739/#comment278440> 1] https://reviews.apache.org/r/65567/ is using the same DB patch # (030). Use the next available #. 2] Make this DB change available for other DB flavors 3] Update consolidated DB schema script with the DB changes security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java Lines 1124 (patched) <https://reviews.apache.org/r/65739/#comment278441> Fix PMD violations such as below.. ``` [INFO] --- maven-pmd-plugin:3.7:check (default) @ security-admin-web --- [INFO] PMD Failure: org.apache.ranger.biz.AssetMgr:1124 Rule:UnusedLocalVariable Priority:3 Avoid unused local variables such as 'vxUgsyncAuditInfo'.. [INFO] PMD Failure: org/apache/ranger/db/XXUgsyncAuditInfoDao.java:23 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.ranger.entity.XXPluginInfo'. [INFO] PMD Failure: org/apache/ranger/service/XUgsyncAuditInfoService.java:22 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.commons.lang.StringUtils'. [INFO] PMD Failure: org/apache/ranger/service/XUgsyncAuditInfoService.java:23 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.ranger.authorization.hadoop.constants.RangerHadoopConstants'. [INFO] PMD Failure: org/apache/ranger/service/XUgsyncAuditInfoService.java:28 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.ranger.entity.XXAccessAudit'. [INFO] PMD Failure: org/apache/ranger/service/XUgsyncAuditInfoService.java:29 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.ranger.entity.XXService'. [INFO] PMD Failure: org/apache/ranger/service/XUgsyncAuditInfoService.java:30 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.ranger.entity.XXServiceDef'. [INFO] PMD Failure: org/apache/ranger/service/XUgsyncAuditInfoService.java:32 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.ranger.view.VXAccessAudit'. [INFO] PMD Failure: org/apache/ranger/service/XUgsyncAuditInfoService.java:33 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.ranger.view.VXAccessAuditList'. [INFO] PMD Failure: org/apache/ranger/service/XUgsyncAuditInfoService.java:41 Rule:UnusedImports Priority:4 Avoid unused imports such as 'java.util.Date'. [INFO] PMD Failure: org/apache/ranger/service/XUgsyncAuditInfoServiceBase.java:27 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.ranger.entity.XXAccessAudit'. [INFO] PMD Failure: org/apache/ranger/service/XUgsyncAuditInfoServiceBase.java:29 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.ranger.view.VXAccessAudit'. [INFO] PMD Failure: org/apache/ranger/service/XUgsyncAuditInfoServiceBase.java:30 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.ranger.view.VXAccessAuditList'. [INFO] PMD Failure: org/apache/ranger/view/VXLdapSyncSourceInfo.java:33 Rule:UnusedImports Priority:4 Avoid unused imports such as 'java.util.List'. [INFO] PMD Failure: org/apache/ranger/view/VXUgsyncAuditInfo.java:36 Rule:UnusedImports Priority:4 Avoid unused imports such as 'java.util.List'. ``` - Velmurugan Periasamy On Feb. 26, 2018, 11:56 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65739/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2018, 11:56 p.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan > Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1985 > https://issues.apache.org/jira/browse/RANGER-1985 > > > Repository: ranger > > > Description > ------- > > Added code to support auditing for Ranger Usersync operations. This includes > auditing for all the sync sources (unix, file, and LDAP/AD) for every sync > interval. Also includes Rest API for showing these audits in Ranger UI. > > > Diffs > ----- > > > security-admin/db/mysql/patches/030-create-schema-for-usersync-audit-info.sql > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 034053d2 > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java cecb3f8b > security-admin/src/main/java/org/apache/ranger/common/AppConstants.java > 4a02e26b > security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java > db20a14a > security-admin/src/main/java/org/apache/ranger/db/XXUgsyncAuditInfoDao.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/entity/XXUgsyncAuditInfo.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 3c274e3f > security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java a07c243a > > security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java > 460c7fda > > security-admin/src/main/java/org/apache/ranger/service/XUgsyncAuditInfoService.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/service/XUgsyncAuditInfoServiceBase.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/view/VXFileSyncSourceInfo.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/view/VXLdapSyncSourceInfo.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/view/VXUgsyncAuditInfo.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/view/VXUgsyncAuditInfoList.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/view/VXUnixSyncSourceInfo.java > PRE-CREATION > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 786b4bfd > security-admin/src/main/resources/META-INF/persistence.xml 20f5bbac > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java > 2852b320 > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java > 18366ef1 > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java > 6b2648d9 > > ugsync/src/main/java/org/apache/ranger/unixusersync/model/FileSyncSourceInfo.java > PRE-CREATION > > ugsync/src/main/java/org/apache/ranger/unixusersync/model/LdapSyncSourceInfo.java > PRE-CREATION > > ugsync/src/main/java/org/apache/ranger/unixusersync/model/UgsyncAuditInfo.java > PRE-CREATION > > ugsync/src/main/java/org/apache/ranger/unixusersync/model/UnixSyncSourceInfo.java > PRE-CREATION > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilder.java > 713c8688 > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java > 864d884d > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java > 60ce08d1 > ugsync/src/main/java/org/apache/ranger/usergroupsync/UserGroupSink.java > 494efc21 > > > Diff: https://reviews.apache.org/r/65739/diff/2/ > > > Testing > ------- > > 1. Tested with different types of sync sources (Unix, File, and LDAP/AD) > 2. Also tested with incremental sync enabled for AD sync source. > 3. Tested the Rest API for showing audits in Ranger UI. > > > Thanks, > > Sailaja Polavarapu > >
