----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65990/#review198900 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On March 8, 2018, 6:44 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65990/ > ----------------------------------------------------------- > > (Updated March 8, 2018, 6:44 p.m.) > > > Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy. > > > Bugs: RANGER-2000 > https://issues.apache.org/jira/browse/RANGER-2000 > > > Repository: ranger > > > Description > ------- > > NPE in ValiditySchedule validation code. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java > 63e8bc0f9 > > agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-invalid.json > ed62828f4 > > agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid-and-applicable.json > 38921d7fe > > > Diff: https://reviews.apache.org/r/65990/diff/1/ > > > Testing > ------- > > Added more unit test cases. > > > Thanks, > > Abhay Kulkarni > >