> On March 8, 2018, 11:12 a.m., Velmurugan Periasamy wrote: > > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java > > Line 360 (original), 360 (patched) > > <https://reviews.apache.org/r/65978/diff/3/?file=1972508#file1972508line360> > > > > With this approach, update is not retricted, but actually succeeds. Any > > particular reason?
user sync source is of int datatype which shall have default value ‘0’. Whenever user is not sending user sync source but still want to update the other fields, in that case if existing sync source is 1 then we can’t know the new sync source value 0 is explicitly set by user or not. so because of this case if we want to fail then user need to know the existing sync source and sending of sync source shall be mandatory irrespective of whether he intend to update sync source or not. - Fatima ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65978/#review198874 ----------------------------------------------------------- On March 8, 2018, 7:18 a.m., Fatima Khan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65978/ > ----------------------------------------------------------- > > (Updated March 8, 2018, 7:18 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and > Sailaja Polavarapu. > > > Bugs: RANGER-2013 > https://issues.apache.org/jira/browse/RANGER-2013 > > > Repository: ranger > > > Description > ------- > > Improvise validation in user profile to handle retention of original user > source. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 487fefa > > > Diff: https://reviews.apache.org/r/65978/diff/3/ > > > Testing > ------- > > Tested and validated the update user Api. > > > Thanks, > > Fatima Khan > >
