[ https://issues.apache.org/jira/browse/RANGER-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395240#comment-16395240 ]
Pradeep Agrawal commented on RANGER-1991: ----------------------------------------- [~zsombor] : I think I should commit my proposed patch in Ranger-1.0 branch and later you can commit your patch in the master branch? CC: [~coheig] / [~vperiasamy] > Fix problems detected by static code analysis > --------------------------------------------- > > Key: RANGER-1991 > URL: https://issues.apache.org/jira/browse/RANGER-1991 > Project: Ranger > Issue Type: Bug > Components: admin > Affects Versions: 0.7.1 > Reporter: Zsombor Gegesy > Assignee: Zsombor Gegesy > Priority: Blocker > Labels: code-cleanup, findbugs > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1991-Import-policy-failure-fix-caused-by-stat.patch, > RANGER-1991-fix.patch, RANGER-1991.patch > > > FindBugs/SpotBug detects a couple of problems with the code base: > * Incorrect class casting - in XXServiceDef.equals > * Unnecessary NPE checks - for variables which is known to be non-null (for > example, because in other places a method is called on that object). In > ServiceREST.java PublicAPIs.java, ServiceUtil.java and independently in > XUserMgr.java > * Collection.contains method call which is never true - in > ServiceDBStore.validatePolicyItems for policyItem.getAccesses().contains("") > - because getAccesses doesn't store String objects > * Making public partially initialized objects in > HadoopConfigHolder.initResourceMap() > * Calling toString on array, which is not too readable > -- This message was sent by Atlassian JIRA (v7.6.3#76005)