----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66079/#review199325 -----------------------------------------------------------
Minor quibble - avoid creating unnecessary variables, e.g.: > ProjectInstance project = getProjectInstance(name); > return project; could simply be: return getProjectInstance(name); Same goes for: > ProjectInstance project = ProjectInstance.create(name, owner, description, > overrideProps, realizationEntries, models); > return project; - Colm O hEigeartaigh On March 15, 2018, 6:55 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66079/ > ----------------------------------------------------------- > > (Updated March 15, 2018, 6:55 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, > Selvamohan Neethiraj, sam rome, Venkat Ranganathan, and Velmurugan Periasamy. > > > Bugs: RANGER-1808 > https://issues.apache.org/jira/browse/RANGER-1808 > > > Repository: ranger > > > Description > ------- > > Write unit test for RANGER-1672 kylin plugin > > > Diffs > ----- > > plugin-kylin/pom.xml bfce4c1 > > plugin-kylin/src/test/java/org/apache/ranger/authorization/kylin/authorizer/RangerAdminClientImpl.java > PRE-CREATION > > plugin-kylin/src/test/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizerTest.java > PRE-CREATION > plugin-kylin/src/test/resources/applicationContext.xml PRE-CREATION > plugin-kylin/src/test/resources/kylin-policies.json PRE-CREATION > plugin-kylin/src/test/resources/kylin.properties PRE-CREATION > plugin-kylin/src/test/resources/kylinSecurity.xml PRE-CREATION > plugin-kylin/src/test/resources/log4j.properties PRE-CREATION > plugin-kylin/src/test/resources/ranger-kylin-security.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/66079/diff/1/ > > > Testing > ------- > > Test > 1.eclipse->Run as->Junit Test > 2.mvn test > > > Thanks, > > Qiang Zhang > >