----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66102/#review199381 -----------------------------------------------------------
Fix it, then Ship it! tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHdfsResourceMapper.java Lines 64 (patched) <https://reviews.apache.org/r/66102/#comment279700> It will be helpful to see sample configurations, as shown below, here and in ranger-tagsync-site.xml: ## service-name for HDFS in 'cl1' cluster, that service nameService 'ns1' ranger.tagsync.atlas.hdfs.instance.cl1.nameservice.ns1.ranger.service=cl1_hdfs_ns1 ## service-name for HDFS in 'cl2' cluster, with no specific nameService ranger.ragsync.atlas.hdfs.instance.cl2.ranger.service=cl2_hdfs - Madhan Neethiraj On March 15, 2018, 10:15 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66102/ > ----------------------------------------------------------- > > (Updated March 15, 2018, 10:15 p.m.) > > > Review request for ranger, Apoorv Naik, Madhan Neethiraj, Vishal Suvagia, and > Velmurugan Periasamy. > > > Bugs: RANGER-2024 > https://issues.apache.org/jira/browse/RANGER-2024 > > > Repository: ranger > > > Description > ------- > > HDFS entity contained in entity notification includes a name-service-id in > case a federated hdfs file/directory is associated with a classification(i.e. > tag). tagsync needs to be able to handle such entities and map them correctly > to appropriate service-resource in Ranger. > > > Diffs > ----- > > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHdfsResourceMapper.java > 378542cd8 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapper.java > 5d067a5b4 > > tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHdfsResourceMapper.java > 627690405 > > > Diff: https://reviews.apache.org/r/66102/diff/1/ > > > Testing > ------- > > Developed and passed unit tests. > > > Thanks, > > Abhay Kulkarni > >
