----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66242/#review200022 -----------------------------------------------------------
Ship it! Ship It! - Qiang Zhang On March 23, 2018, 9:45 a.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66242/ > ----------------------------------------------------------- > > (Updated March 23, 2018, 9:45 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-2035 > https://issues.apache.org/jira/browse/RANGER-2035 > > > Repository: ranger > > > Description > ------- > > Oracle treats empty strings and nulls as equals - if an empty string is > inserted, later, it returns as NULL. > This cause problems when a service def is created, with implementation > classname specified as a zero length string. However, when later it is > retrieved or updated or delete, Ranger throws various exceptions. In 1.0.0 it > fails because RangerBizUtil.hasAccess returns false for everyone, so no one > can see, update or delete these servicedefs. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java > d7e9e335e > > > Diff: https://reviews.apache.org/r/66242/diff/1/ > > > Testing > ------- > > Tested with oracle db > > > Thanks, > > Zsombor Gegesy > >
