----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66584/#review201318 -----------------------------------------------------------
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java Lines 237 (patched) <https://reviews.apache.org/r/66584/#comment282493> Does this need to be public? ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java Lines 751 (patched) <https://reviews.apache.org/r/66584/#comment282494> Would a debug message here be useful? Similar to line 757? ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java Lines 796 (patched) <https://reviews.apache.org/r/66584/#comment282496> Debug message (similar to line 802 - in non-cookie case) would be helpful. ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java Lines 1216 (patched) <https://reviews.apache.org/r/66584/#comment282497> This can be moved out of if check to make it common for both cookie and non-cookie cases. - Velmurugan Periasamy On April 17, 2018, 3:03 p.m., Nikhil P wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66584/ > ----------------------------------------------------------- > > (Updated April 17, 2018, 3:03 p.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan > Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2021 and RANGER-2064 > https://issues.apache.org/jira/browse/RANGER-2021 > https://issues.apache.org/jira/browse/RANGER-2064 > > > Repository: ranger > > > Description > ------- > > Ranger Usersync should use cookie based authentication for subsequent > requests to Ranger admin. > > > Diffs > ----- > > > ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java > e9e356a > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java > b30b051 > unixauthservice/conf.dist/ranger-ugsync-default.xml cf4ab80 > > > Diff: https://reviews.apache.org/r/66584/diff/3/ > > > Testing > ------- > > 1)Validated rangerusersync is not flooding table. > 2)Validated if cookie is used by usersync client for subsequent requests to > ranger-admin. > > > Thanks, > > Nikhil P > >
