----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67117/#review203065 -----------------------------------------------------------
tagsync/src/main/java/org/apache/ranger/tagsync/model/TagSyncThreadListener.java Lines 23 (patched) <https://reviews.apache.org/r/67117/#comment285116> Passing "TagSource" instead of a name, would make the implementation simpler. tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java Line 48 (original), 50 (patched) <https://reviews.apache.org/r/67117/#comment285117> ... so no name->TagSource mapping would needed tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java Lines 301 (patched) <https://reviews.apache.org/r/67117/#comment285118> ... so the TagSource object will be passed as a method argument tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java Lines 315 (patched) <https://reviews.apache.org/r/67117/#comment285119> getTagSourceFromConfig(...) will create a new TagSource object. Why don't you put the original 'tagSourceToStop' into the 'failedTagSources' list? tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java Lines 57 (patched) <https://reviews.apache.org/r/67117/#comment285120> This new 'listeners' variable is not used in the class, as addListener/removeListener delegates to the ConsumerRunnable, so you don't need it. - Zsombor Gegesy On May 14, 2018, 8:10 p.m., Felix Albani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67117/ > ----------------------------------------------------------- > > (Updated May 14, 2018, 8:10 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-2078 > https://issues.apache.org/jira/browse/RANGER-2078 > > > Repository: ranger > > > Description > ------- > > RANGER-2078 > > > Diffs > ----- > > > tagsync/src/main/java/org/apache/ranger/tagsync/model/AbstractTagSource.java > da4c5cbd3 > tagsync/src/main/java/org/apache/ranger/tagsync/model/TagSink.java > b5dcc7526 > tagsync/src/main/java/org/apache/ranger/tagsync/model/TagSource.java > eb7981411 > > tagsync/src/main/java/org/apache/ranger/tagsync/model/TagSyncThreadListener.java > PRE-CREATION > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java > 6d27b02cd > > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java > 49ff76fb2 > > tagsync/src/main/java/org/apache/ranger/tagsync/sink/tagadmin/TagAdminRESTSink.java > 331f783db > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java > ea4c20cc5 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java > 2b4a668b8 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/file/FileTagSource.java > f0a3fd003 > > > Diff: https://reviews.apache.org/r/67117/diff/1/ > > > Testing > ------- > > Only been tested in local cluster. Haven't created tests for this as I'm not > sure how to simulate a RuntimeException. > > > Thanks, > > Felix Albani > >
