----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67475/#review204491 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java Line 83 (original), 83 (patched) <https://reviews.apache.org/r/67475/#comment286969> Could you please regenerate this patch? Not able to apply. Code seems fine. ``` $ git apply --check -v < ~/Downloads/RANGER-2123.1.patch Checking patch src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java... error: src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java: No such file or directory Checking patch src/main/webapp/scripts/prelogin/XAPrelogin.js... error: src/main/webapp/scripts/prelogin/XAPrelogin.js: No such file or directory ``` - Velmurugan Periasamy On June 6, 2018, 1:10 p.m., daniel voros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67475/ > ----------------------------------------------------------- > > (Updated June 6, 2018, 1:10 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-2123 > https://issues.apache.org/jira/browse/RANGER-2123 > > > Repository: ranger > > > Description > ------- > > Leaving the pass empty will result in a JS error, while a wrong password will > get the server response: > ``` > The username or password you entered is incorrect.. > ``` > vs > ``` > The username or password you entered is incorrect... > ``` > Lets go with a single '.' in both cases! > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java > 35d75438f > security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js b2e5515dc > > > Diff: https://reviews.apache.org/r/67475/diff/1/ > > > Testing > ------- > > > Thanks, > > daniel voros > >
