> On Aug. 6, 2018, 8:16 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceValidator.java > > Lines 43 (patched) > > <https://reviews.apache.org/r/68186/diff/2/?file=2068660#file2068660line44> > > > > Do we really need a hash table here? It appears that there is only one > > regular expression string to be compiled into Pattern. Is having a static > > Pattern sufficient for this validation?
Yes. Static Pattern is sufficient > On Aug. 6, 2018, 8:16 p.m., Abhay Kulkarni wrote: > > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > > Lines 638 (patched) > > <https://reviews.apache.org/r/68186/diff/2/?file=2068662#file2068662line638> > > > > Is it allowed to have service-name consisting entirely of blank > > characters? Its not allowed. We will get the vaidation message "Missing service name" from server side. - bhavik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68186/#review206901 ----------------------------------------------------------- On Aug. 7, 2018, 1:21 p.m., bhavik patel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68186/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2018, 1:21 p.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan > Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, > and Velmurugan Periasamy. > > > Bugs: RANGER-2181 > https://issues.apache.org/jira/browse/RANGER-2181 > > > Repository: ranger > > > Description > ------- > > Code Improvement To Follow Best Practices. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java > 41052dd > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceValidator.java > 1893fb9 > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceValidator.java > 64ccb7d > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > c116ea2 > security-admin/src/main/webapp/scripts/models/RangerServiceDef.js 9945044 > security-admin/src/main/webapp/styles/xa.css db96ed2 > security-admin/src/main/webapp/templates/helpers/XAHelpers.js 8ace4d7 > > > Diff: https://reviews.apache.org/r/68186/diff/3/ > > > Testing > ------- > > 1. Tested Ranger Admin & Ranger KMS rest calls. > > > Thanks, > > bhavik patel > >
