----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68269/#review206988 -----------------------------------------------------------
ranger-atlas-plugin-shim/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java Lines 25 (patched) <https://reviews.apache.org/r/68269/#comment290149> I am getting below compilation error in master branch. Could you please clarify if any atlas dependencies need to be changed? ``` [INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /Users/vperiasamy/git/tlp-ranger/master/ranger/ranger-atlas-plugin-shim/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java:[25,33] error: cannot find symbol [ERROR] symbol: class AtlasRelationshipAccessRequest location: package org.apache.atlas.authorize /Users/vperiasamy/git/tlp-ranger/master/ranger/ranger-atlas-plugin-shim/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java:[182,32] error: cannot find symbol [ERROR] symbol: class AtlasRelationshipAccessRequest location: class RangerAtlasAuthorizer /Users/vperiasamy/git/tlp-ranger/master/ranger/ranger-atlas-plugin-shim/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java:[112,16] error: name clash: isAccessAllowed(AtlasAdminAccessRequest) in RangerAtlasAuthorizer overrides a method whose erasure is the same as another method, yet neither overrides the other [ERROR] first method: isAccessAllowed(AtlasTypeAccessRequest) in RangerAtlasAuthorizer second method: isAccessAllowed(AtlasRelationshipAccessRequest) in RangerAtlasAuthorizer /Users/vperiasamy/git/tlp-ranger/master/ranger/ranger-atlas-plugin-shim/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java:[135,16] error: name clash: isAccessAllowed(AtlasEntityAccessRequest) in RangerAtlasAuthorizer overrides a method whose erasure is the same as another method, yet neither overrides the other [ERROR] first method: isAccessAllowed(AtlasTypeAccessRequest) in RangerAtlasAuthorizer second method: isAccessAllowed(AtlasRelationshipAccessRequest) in RangerAtlasAuthorizer /Users/vperiasamy/git/tlp-ranger/master/ranger/ranger-atlas-plugin-shim/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java:[158,16] error: name clash: isAccessAllowed(AtlasTypeAccessRequest) in RangerAtlasAuthorizer overrides a method whose erasure is the same as another method, yet neither overrides the other ``` - Velmurugan Periasamy On Aug. 8, 2018, 4:47 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68269/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2018, 4:47 p.m.) > > > Review request for ranger, Madhan Neethiraj, Mehul Parikh, and Velmurugan > Periasamy. > > > Bugs: RANGER-2184 > https://issues.apache.org/jira/browse/RANGER-2184 > > > Repository: ranger > > > Description > ------- > > This patch includes update to RangerAtlas authorization to provide > authorization for Relationship with > > Actions : add-relationship, update-relationship, remove-relationship > > > Diffs > ----- > > > plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java > aa815b266 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java > 0ee262796 > > ranger-atlas-plugin-shim/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java > 609dddb24 > > > Diff: https://reviews.apache.org/r/68269/diff/2/ > > > Testing > ------- > > Tested authorization with policies on end1 & end2 of entity-type and > classification. > > > Thanks, > > Nixon Rodrigues > >
