-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68286/
-----------------------------------------------------------

(Updated Aug. 15, 2018, 10:06 p.m.)


Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan 
Periasamy.


Changes
-------

Addressed review comment


Bugs: RANGER-2186
    https://issues.apache.org/jira/browse/RANGER-2186


Repository: ranger


Description
-------

Policy updates to different policies within a service, when successful, update 
the service's policy version. If the update transactions are concurrent, and 
executed on different ranger-admin servers (in HA configuration), then it is 
possible that policy-version of the transaction that commits later overwrites 
policy-version of earlier transaction, effectively losing track of the first 
change.

If policy-version is updated after update to policy is committed, then the 
window of such loss is greatly reduced.

Similar considerations apply for tag updates.


Diffs (updated)
-----

  
agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java
 69ded6dc8 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
0773616f9 
  
security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java
 2a62fb408 
  security-admin/src/main/java/org/apache/ranger/db/RangerDaoManager.java 
2788a6109 
  security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java 
da89e041c 
  
security-admin/src/main/java/org/apache/ranger/db/XXServiceVersionInfoDao.java 
e1003297a 
  security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 
cb496ea8b 


Diff: https://reviews.apache.org/r/68286/diff/3/

Changes: https://reviews.apache.org/r/68286/diff/2-3/


Testing
-------

Passed all unit tests


Thanks,

Abhay Kulkarni

Reply via email to