> On Oct. 2, 2018, 9:06 p.m., Velmurugan Periasamy wrote: > > knox-agent/src/test/java/org/apache/ranger/services/knox/KnoxRangerTest.java > > Lines 46 (patched) > > <https://reviews.apache.org/r/67697/diff/3/?file=2092586#file2092586line46> > > > > Upgrading to 25.1-jre is a good idea. > > > > Instead of ignoring the test, my suggestion is to fix the issue. > > > > Also if this JIRA is going to be used only for Guava upgrade, please > > update the description in RR and JIRA. For spring version upgrade, please > > create a new JIRA. Thanks.
+1 to fixiing the issue. Weirdly, just uncommenting "ranger.root.logger=WARN,console" in src/test/resources/log4j.properties makes the tests pass, so I guess thre is some sort of timing issue. - Colm ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67697/#review209162 ----------------------------------------------------------- On June 25, 2018, 10:26 a.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67697/ > ----------------------------------------------------------- > > (Updated June 25, 2018, 10:26 a.m.) > > > Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul > Parikh, suja s, and Velmurugan Periasamy. > > > Bugs: RANGER-2140 > https://issues.apache.org/jira/browse/RANGER-2140 > > > Repository: ranger > > > Description > ------- > > Here I am proposing to change Guava version to only 17.0, currently there are > three different version are being used. Also proposing to change Spring > Security to 4.2.7 and Spring Framework to 4.3.18. > > > Diffs > ----- > > kms/pom.xml 6fc190f35 > > knox-agent/src/test/java/org/apache/ranger/services/knox/KnoxRangerTest.java > 764192172 > plugin-atlas/pom.xml fcc037f93 > pom.xml e6695b440 > src/main/assembly/kms.xml 7fbc1410c > src/main/assembly/plugin-atlas.xml 8f4a64cb6 > src/main/assembly/plugin-kms.xml 6d15f2a10 > src/main/assembly/plugin-solr.xml de30bfb13 > ugsync/pom.xml f4c24e739 > unixauthclient/pom.xml cd3d15604 > unixauthservice/pom.xml 2c0ed2eef > > > Diff: https://reviews.apache.org/r/67697/diff/3/ > > > Testing > ------- > > Tested Ranger admin installation, user login, usersync and other crud > operations on service, policy, user and group module. > > > Thanks, > > Pradeep Agrawal > >
