----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68855/#review209277 -----------------------------------------------------------
plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java Line 43 (original), 43 (patched) <https://reviews.apache.org/r/68855/#comment293568> Could you please fix PMD violations? Thanks. ``` [INFO] --- maven-pmd-plugin:3.7:check (default) @ ranger-kafka-plugin --- [INFO] PMD Failure: org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java:43 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.ranger.plugin.audit.RangerDefaultAuditHandler'. [INFO] PMD Failure: org.apache.ranger.authorization.kafka.authorizer.KafkaRangerTopicCreationTest:197 Rule:UnusedPrivateMethod Priority:3 Avoid unused private methods such as 'checkTopicExists(KafkaConsumer)'.. [INFO] PMD Failure: org.apache.ranger.authorization.kafka.authorizer.KafkaRangerTopicCreationTest:207 Rule:UnusedPrivateMethod Priority:3 Avoid unused private methods such as 'sendMessage(Producer)'.. ``` plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerTopicCreationTest.java Lines 197 (patched) <https://reviews.apache.org/r/68855/#comment293569> Same as above. plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerTopicCreationTest.java Lines 207 (patched) <https://reviews.apache.org/r/68855/#comment293570> Same as above. - Velmurugan Periasamy On Oct. 5, 2018, 3:43 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68855/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2018, 3:43 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan > Periasamy. > > > Bugs: RANGER-2222 > https://issues.apache.org/jira/browse/RANGER-2222 > > > Repository: ranger > > > Description > ------- > > RANGER-2222: Apache RangerKafkaPlugin support to handle Kafka Cluster as a > new resource > > > Diffs > ----- > > agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json > ca3e0fe > > plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuditHandler.java > PRE-CREATION > > plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java > eab869a > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerGSSTest.java > c1386fe > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerTopicCreationTest.java > PRE-CREATION > plugin-kafka/src/test/resources/kafka-policies.json 0c07604 > plugin-kafka/src/test/resources/kafka_kerberos.jaas 1de804b > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 3f23b00 > security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql > bafdb96 > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > 2bc58ac > > security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql > 1b64eea > security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql > 4a216fe > > security-admin/src/main/java/org/apache/ranger/patch/PatchForKafkaServiceDefUpdate_J10025.java > PRE-CREATION > src/main/assembly/plugin-kafka.xml 97ff8ad > > > Diff: https://reviews.apache.org/r/68855/diff/4/ > > > Testing > ------- > > - This patch addresses "Cluster" and "DelegationToken" as resource in Ranger > plugin. > - Tested in local vm and added unit test for TopicCreation. > - Upgrade patch tested for default policy creation for cluster and delegation > token as resource. > > > Thanks, > > Ramesh Mani > >
