[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738293#comment-16738293 ]
Csaba Koncz commented on RANGER-2255: ------------------------------------- [~pradeep.agrawal]: updated the review at [https://reviews.apache.org/r/69693/] so that JavaScript testing is not done unless explicitly requested. I.e. {code:java} mvn clean verify -am pl security-admin{code} will run only Java tests and will not try to install Karma, Mocha and PhantomJS. The command to run JS tests is: {code:java} mvn clean verify -am pl security-admin -DskipJSTests=false{code} (we might want to add this to the Travis config) Is this acceptable? > Add JavaScript unit tests > ------------------------- > > Key: RANGER-2255 > URL: https://issues.apache.org/jira/browse/RANGER-2255 > Project: Ranger > Issue Type: Wish > Components: admin > Affects Versions: 0.7.0, 2.0.0, 1.2.1 > Reporter: Csaba Koncz > Assignee: Csaba Koncz > Priority: Minor > Fix For: 2.0.0 > > > It would be nice if the admin-ui project would have JavaScript unit tests. > As with RANGER-2220 JavaScript minification was introduced, that can lead to > new type of loading errors that were not seen before. > It would be nice if there was an automatic check that validates the minified > output. -- This message was sent by Atlassian JIRA (v7.6.3#76005)