----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69693/#review211824 -----------------------------------------------------------
Ship it! Ship It! - Zsombor Gegesy On Jan. 10, 2019, 8:46 a.m., Csaba Koncz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69693/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2019, 8:46 a.m.) > > > Review request for ranger. > > > Repository: ranger > > > Description > ------- > > Phantomjs package was renamed to phantomjs-prebuilt. It is automatically > downloaded as a transitive dependency of Karma-phantomjs-launcher > > > Diffs > ----- > > security-admin/src/main/webapp/package-lock.json fbb3e6bf9 > security-admin/src/main/webapp/package.json 060b765ff > > > Diff: https://reviews.apache.org/r/69693/diff/3/ > > > Testing > ------- > > `mvn clean verify -am -pl security-admin` succeeds: > ``` > ... > [INFO] > [INFO] --- frontend-maven-plugin:1.6:karma (karma prd) @ security-admin-web > --- > [INFO] Running 'karma start ../src/test/javascript/karma-prd.conf.js' in > /Users/ckoncz/work/git/hwx/ranger/security-admin/target > [INFO] 08 01 2019 12:21:35.542:INFO [karma-server]: Karma v3.1.4 server > started at http://0.0.0.0:9876/ > [INFO] 08 01 2019 12:21:35.545:INFO [launcher]: Launching browsers PhantomJS > with concurrency unlimited > [INFO] 08 01 2019 12:21:35.560:INFO [launcher]: Starting browser PhantomJS > [INFO] 08 01 2019 12:21:36.592:INFO [PhantomJS 2.1.1 (Mac OS X 0.0.0)]: > Connected on socket IKx-RvUUMj7kLzZlAAAA with id 31183876 > LOG: 'just before loading Main' > [INFO] PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 0 of 1 SUCCESS (0 secs / 0 > secs) > [INFO] 08 01 2019 12:21:36.825:WARN [web-server]: 404: > /service/plugins/csrfconf > [INFO] 08 01 2019 12:21:36.835:WARN [web-server]: 404: > /service/users/profile?_=1546946496706 > [INFO] 08 01 2019 12:21:36.866:WARN [web-server]: 404: /images/avatar.png > LOG: 'initialize a Communicator' > [INFO] PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 0 of 1 SUCCESS (0 secs / 0 > secs) > LOG: 'Initialize a Region Manager' > LOG: 'initialize a Controller Controller' > LOG: 'initialized a TopNav ItemView' > LOG: 'initialized a ProfileBar ItemView' > LOG: 'initialized a Footer ItemView' > LOG: 'Error in service/plugins/checksso REST call404' > LOG: 'initialized a ErrorView ItemView' > LOG: 'mainModule.success=false' > PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 1 of 1 SUCCESS (0.161 secs > / 0.153 secs) > [INFO] TOTAL: 1 SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] ranger 2.0.0-SNAPSHOT .............................. SUCCESS [ 4.431 > s] > [INFO] Credential Support ................................. SUCCESS [ 5.325 > s] > [INFO] Audit Component .................................... SUCCESS [ 3.359 > s] > [INFO] Common library for Plugins ......................... SUCCESS [ 10.998 > s] > [INFO] Ranger Util ........................................ SUCCESS [ 2.430 > s] > [INFO] Unix Authentication Client ......................... SUCCESS [ 1.532 > s] > [INFO] Security Admin Web Application 2.0.0-SNAPSHOT ...... SUCCESS [01:53 > min] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 02:21 min > [INFO] Finished at: 2019-01-08T12:21:36+01:00 > [INFO] > ------------------------------------------------------------------------ > ``` > > Then: > ``` > $ cd security-admin/target/ > $ rm -rf node_modules/ > $ ./node/npm install > > > fsevents@1.2.4 install > > /Users/ckoncz/work/git/hwx/ranger/security-admin/target/node_modules/fsevents > > node install > > [fsevents] Success: > "/Users/ckoncz/work/git/hwx/ranger/security-admin/target/node_modules/fsevents/lib/binding/Release/node-v64-darwin-x64/fse.node" > already installed > Pass --update-binary to reinstall or --build-from-source to recompile > > > phantomjs-prebuilt@2.1.16 install > > /Users/ckoncz/work/git/hwx/ranger/security-admin/target/node_modules/phantomjs-prebuilt > > node install.js > > PhantomJS not found on PATH > Download already available at > /var/folders/w4/g4qllvkd47s768_0btqzk3700000gp/T/phantomjs/phantomjs-2.1.1-macosx.zip > Verified checksum of previously downloaded file > Extracting zip contents > Removing > /Users/ckoncz/work/git/hwx/ranger/security-admin/target/node_modules/phantomjs-prebuilt/lib/phantom > Copying extracted folder > /var/folders/w4/g4qllvkd47s768_0btqzk3700000gp/T/phantomjs/phantomjs-2.1.1-macosx.zip-extract-1546946627976/phantomjs-2.1.1-macosx > -> > /Users/ckoncz/work/git/hwx/ranger/security-admin/target/node_modules/phantomjs-prebuilt/lib/phantom > Writing location.js file > Done. Phantomjs binary available at > /Users/ckoncz/work/git/hwx/ranger/security-admin/target/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs > npm WARN security-admin@2.0.0 No description > npm WARN security-admin@2.0.0 No repository field. > npm WARN security-admin@2.0.0 No license field. > > added 417 packages from 1079 contributors and audited 2496 packages in 6.798s > found 0 vulnerabilities > > ``` > > i.e. a single Phantomjs version is downloaded (as opposed to two as it was > before). > > > Thanks, > > Csaba Koncz > >
