> On Jan. 16, 2019, 4:26 p.m., Zsombor Gegesy wrote: > > What about changing to "TLSv1.2"?
I think it's better just to leave it as "TLS", and leave the protocol specifics to the version of Java that is installed. - Colm ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69740/#review212075 ----------------------------------------------------------- On Jan. 14, 2019, 11:20 a.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69740/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2019, 11:20 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-2322 > https://issues.apache.org/jira/browse/RANGER-2322 > > > Repository: ranger > > > Description > ------- > > There are a few instances in the code of SSLContext.getInstance("SSL"). > Instead we should use "TLS". > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java > f592ed4e7 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSslHelper.java > 2036661e8 > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java > f653b81f3 > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java > cb9b51c95 > > > Diff: https://reviews.apache.org/r/69740/diff/1/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >