----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70280/#review213949 -----------------------------------------------------------
Ship it! Ship It! - madhan On March 22, 2019, 10:24 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70280/ > ----------------------------------------------------------- > > (Updated March 22, 2019, 10:24 p.m.) > > > Review request for ranger, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, and > Velmurugan Periasamy. > > > Bugs: RANGER-2371 > https://issues.apache.org/jira/browse/RANGER-2371 > > > Repository: ranger > > > Description > ------- > > 1. When a zone policy is changed, the plugin doesn’t refresh policies. > 2. When a unzoned policy changes, the plugin downloaded the policies – but > all zone information is lost. > > This observed behavior was a result of plugin not processing policy-deltas in > a zone-aware way. > > The fix correctly computes resulting zone policies from deltas and builds > engine from computed aggregate policies. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > c00f072a6 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > 8b51c631c > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 9081af28d > > agents-common/src/main/java/org/apache/ranger/plugin/util/ServicePolicies.java > 7eb2bb338 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > 9bd5e24fb > > agents-common/src/test/resources/policyengine/test_policyengine_hdfs_zones.json > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 602eb3fcc > > > Diff: https://reviews.apache.org/r/70280/diff/3/ > > > Testing > ------- > > Developed a unit test for zone-based policies. Tested with a live cluster to > ensure that the aggregate zone policies are correctly computed. > > > Thanks, > > Abhay Kulkarni > >
