----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70057/#review214169 -----------------------------------------------------------
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java Lines 176 (patched) <https://reviews.apache.org/r/70057/#comment300361> You can move this repeating pattern to a separate function: void logAndWait(String msg, Exception e) { logger.severe(msg + "[retrying after " + time_interval + " ms]", e); try { Thread.sleep(time_interval); } catch (InterruptedException e) { logger.info("sleep interrupted: " + e.getMessage()); } } embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java Lines 237 (patched) <https://reviews.apache.org/r/70057/#comment300360> In this case, when config is not specified correctly, I don't think re-trying the same would make sense - Zsombor Gegesy On March 27, 2019, 1:04 p.m., bhavik patel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70057/ > ----------------------------------------------------------- > > (Updated March 27, 2019, 1:04 p.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Oliver Szabo, Pradeep Agrawal, Ramesh Mani, > Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2324 > https://issues.apache.org/jira/browse/RANGER-2324 > > > Repository: ranger > > > Description > ------- > > We are handling the solr bootstrapping in below mentioned manner for Ranger > 1.) Connection to solr > 2.) Upload Configuration > 3.) Create Collection > 4.) Setting ACL > > > Diffs > ----- > > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java > 8d32352 > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBoostrapper.java > PRE-CREATION > security-admin/scripts/install.properties fdcee1b > security-admin/scripts/setup.sh bd4bd4c > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > 686f720 > security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 4d4a1de > src/main/assembly/admin-web.xml 0296652 > > > Diff: https://reviews.apache.org/r/70057/diff/10/ > > > Testing > ------- > > Tested Below Scenario on ranger manual start / restart > 1.) Solr configuration were uploaded successfully > 2.) Solr collections were created successfully > 3.) ACL were setup as required. > > > Thanks, > > bhavik patel > >
