----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70817/#review215769 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerMultipleTagsConditionEvaluator.java Lines 35 (patched) <https://reviews.apache.org/r/70817/#comment302601> Indentation agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerMultipleTagsConditionEvaluator.java Lines 49 (patched) <https://reviews.apache.org/r/70817/#comment302600> As init() is called during policy-engine construction, is it likely that either conditionDef or condition will be null? And if they are, is it more appropriate either to throw exception or at the least give warning or error? agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerMultipleTagsConditionEvaluator.java Lines 57 (patched) <https://reviews.apache.org/r/70817/#comment302599> Please consider stripping possible spaces around value before adding them to policyConditionTags. - Abhay Kulkarni On June 7, 2019, 11:42 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70817/ > ----------------------------------------------------------- > > (Updated June 7, 2019, 11:42 p.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, > and Velmurugan Periasamy. > > > Repository: ranger > > > Description > ------- > > RANGER-2465:Create a PolicyCondition to apply if all given tags are present > for the accessed resource > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerMultipleTagsConditionEvaluator.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/70817/diff/1/ > > > Testing > ------- > > Tested in Local VM. > > > Thanks, > > Ramesh Mani > >
