----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70940/#review216141 -----------------------------------------------------------
Fix it, then Ship it! security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Lines 3989 (patched) <https://reviews.apache.org/r/70940/#comment303158> LOG.info("creating tag-service " + context.tagServiceName); security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Lines 3995 (patched) <https://reviews.apache.org/r/70940/#comment303159> LOG.info("created tag-service " + context.tagServiceName); security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Lines 4010 (patched) <https://reviews.apache.org/r/70940/#comment303162> LOG.info("Linking service[" + context.resourceServiceName + " with tag-service " + context.tagServiceName); security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Lines 4014 (patched) <https://reviews.apache.org/r/70940/#comment303163> LOG.error("Failed to link service[" + context.resourceServiceName + " with tag-service " + context.tagServiceName); - Madhan Neethiraj On June 25, 2019, 8:46 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70940/ > ----------------------------------------------------------- > > (Updated June 25, 2019, 8:46 p.m.) > > > Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan > Periasamy. > > > Bugs: RANGER-2481 > https://issues.apache.org/jira/browse/RANGER-2481 > > > Repository: ranger > > > Description > ------- > > Ranger supports tag-based policies out of the box. However, there are a few > configuration steps that need to be performed in order to set up Ranger to > perform tag-based authorization. As these steps are often missed, it will be > useful to provide a commonly used/structured way of automatically creating > tag service and linking it to resource service. > > This may be controlled through few configuration parameters: > > tag.service.auto.create=<true|false> ==> If tag-service needs to be created > when resource-service is created. > > tag.service.name=<auto|tag-service-name> ==> If tag-service needs to be > created, how is it named (automatically or user-specified) > > tag.service.auto.link=<true|false> ==> If resource-service needs to be linked > to the tag-service > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/common/TimedExecutor.java > 6f97337b7 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 1d9391f20 > > > Diff: https://reviews.apache.org/r/70940/diff/2/ > > > Testing > ------- > > Tested by creating a resource service, and ensuring that corresponding tag > service is created and linked with resource service > > > Thanks, > > Abhay Kulkarni > >
