----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71125/#review216768 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On July 19, 2019, 4:55 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71125/ > ----------------------------------------------------------- > > (Updated July 19, 2019, 4:55 p.m.) > > > Review request for ranger, deepak sharma, Madhan Neethiraj, Ramesh Mani, and > Zsombor Gegesy. > > > Bugs: RANGER-2511 > https://issues.apache.org/jira/browse/RANGER-2511 > > > Repository: ranger > > > Description > ------- > > As part of RANER-2481 feature implementation if there is any resource based > service created then one tag based service is created and gets associated > with the resource based service, where tag based service name is string > before underscore + _tag. eg: cm_hive then tag service name is cm_tag. > > The root of the problem was that id of the service-definition of service > being created was being compared with the name of the tag service-definition. > This condition always returned false, and triggered creation of tag service > irrespective of the type of service being created. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 0c7d8527c > > > Diff: https://reviews.apache.org/r/71125/diff/1/ > > > Testing > ------- > > Passed all unit tests. Pending testing with cluster. > > > Thanks, > > Abhay Kulkarni > >
