----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71126/#review216775 -----------------------------------------------------------
agents-audit/pom.xml Lines 45 (patched) <https://reviews.apache.org/r/71126/#comment304004> Please consider not adding more dependencies unless they are needed. agents-common/pom.xml Lines 57 (patched) <https://reviews.apache.org/r/71126/#comment304005> Same as the comment above. agents-common/src/main/resources/service-defs/ranger-servicedef-ozone.json Lines 27 (patched) <https://reviews.apache.org/r/71126/#comment304006> It appears that all accesses appear in all accessTypeRestrictions. This is the default anyway. Do they need to be specified at all? agents-common/src/main/resources/service-defs/ranger-servicedef-ozone.json Lines 103 (patched) <https://reviews.apache.org/r/71126/#comment304007> Please consider adding another access type "all" which implies all supported access-types. It could be useful for writing policies. - Abhay Kulkarni On July 19, 2019, 5:02 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71126/ > ----------------------------------------------------------- > > (Updated July 19, 2019, 5:02 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, > Nitin Galave, Ramesh Mani, and Velmurugan Periasamy. > > > Bugs: RANGER-2325 > https://issues.apache.org/jira/browse/RANGER-2325 > > > Repository: ranger > > > Description > ------- > > Initial implementation of Ranger plugin for Ozone. > > > Diffs > ----- > > agents-audit/pom.xml 4aaec0996 > agents-common/pom.xml 27be45f9d > > agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java > d82fd70ac > agents-common/src/main/resources/service-defs/ranger-servicedef-ozone.json > PRE-CREATION > plugin-ozone/conf/ozone-ranger-env.sh PRE-CREATION > plugin-ozone/conf/ranger-ozone-audit-changes.cfg PRE-CREATION > plugin-ozone/conf/ranger-ozone-audit.xml PRE-CREATION > plugin-ozone/conf/ranger-ozone-security-changes.cfg PRE-CREATION > plugin-ozone/conf/ranger-ozone-security.xml PRE-CREATION > plugin-ozone/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION > plugin-ozone/conf/ranger-policymgr-ssl.xml PRE-CREATION > plugin-ozone/pom.xml PRE-CREATION > plugin-ozone/scripts/install.properties PRE-CREATION > > plugin-ozone/src/main/java/org/apache/ranger/authorization/ozone/authorizer/RangerOzoneAuthorizer.java > PRE-CREATION > > plugin-ozone/src/main/java/org/apache/ranger/services/ozone/RangerServiceOzone.java > PRE-CREATION > > plugin-ozone/src/main/java/org/apache/ranger/services/ozone/client/OzoneClient.java > PRE-CREATION > > plugin-ozone/src/main/java/org/apache/ranger/services/ozone/client/OzoneConnectionMgr.java > PRE-CREATION > > plugin-ozone/src/main/java/org/apache/ranger/services/ozone/client/OzoneResourceMgr.java > PRE-CREATION > pom.xml 7cf134ce5 > ranger-ozone-plugin-shim/pom.xml PRE-CREATION > > ranger-ozone-plugin-shim/src/main/java/org/apache/ranger/authorization/ozone/authorizer/RangerOzoneAuthorizer.java > PRE-CREATION > src/main/assembly/admin-web.xml 39fb05414 > src/main/assembly/plugin-ozone.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/71126/diff/1/ > > > Testing > ------- > > 1. Tested basic Ozone CLI commands like create/show volumne/bucket/key on a > test cluster. > 2. Also tested basic commands using s3 api on test cluster > 3. Verified audits in Ranger admin UI > > > Thanks, > > Sailaja Polavarapu > >
