----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71473/#review217775 -----------------------------------------------------------
Fix it, then Ship it! agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java Lines 353 (patched) <https://reviews.apache.org/r/71473/#comment305157> Consider removing prefix "m" from variables in lines #353 - #357 and #400 - #404. These might be useful to distiguish instance members, but not for local variables. agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java Lines 355 (patched) <https://reviews.apache.org/r/71473/#comment305158> 'keyStoreType' is used only within 'if' block at #365. Consider moving lines #355 & #356 inside this 'if' block. agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java Lines 402 (patched) <https://reviews.apache.org/r/71473/#comment305159> 'trustStoreType' is used only within 'if' block at #412. Consider moving lines #402 & #403 inside this 'if' block. agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerConfiguration.java Lines 205 (patched) <https://reviews.apache.org/r/71473/#comment305160> remove "==> " from the log message at line #205. - Madhan Neethiraj On Sept. 12, 2019, 11:33 a.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71473/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2019, 11:33 a.m.) > > > Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikhil P, Nitin > Galave, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2567 > https://issues.apache.org/jira/browse/RANGER-2567 > > > Repository: ranger > > > Description > ------- > > ** Problem Statement: ** Ranger fails to connect wired SSL through configured > ranger truststore file. Currently it works when solr certificate is added in > jdk ca certs. Though in the file PropertiesUtil.java, truststore related > System properties has been provided its not being considered probably > Ranger's embeded tomcat server starts prior to load of Ranger's truststore > configs via PropertiesUtil.java. > > ** Proposed Solution: ** Proposed patch contain changes in > EmbeddedServer.java file so that truststore related configs can be > initialized prior to Ranger's embeded tomcat server start. > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java > 35487e9fa > > agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java > dac5c9473 > > agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerConfiguration.java > 0c2e47308 > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java > b39212a79 > > > Diff: https://reviews.apache.org/r/71473/diff/5/ > > > Testing > ------- > > Without patch solr collection was failing and after the patch ranger is able > to create solr collection and ranger UI is able to fetch access audit records > from solr. > > > Thanks, > > Pradeep Agrawal > >
