-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71530/
-----------------------------------------------------------

(Updated Sept. 23, 2019, 5:34 p.m.)


Review request for ranger, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, and 
Velmurugan Periasamy.


Changes
-------

Incorporated review comments


Bugs: RANGER-2585
    https://issues.apache.org/jira/browse/RANGER-2585


Repository: ranger


Description
-------

Setting AddedByUserId and UpdatedByUserId from ranger role request instead from 
the user session.


Diffs (updated)
-----

  
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
 0c5449d44 
  
security-admin/src/main/java/org/apache/ranger/common/db/JPABeanCallbacks.java 
226c0606a 
  security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 25fb0858a 
  security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java 
ca4407b06 


Diff: https://reviews.apache.org/r/71530/diff/2/

Changes: https://reviews.apache.org/r/71530/diff/1-2/


Testing
-------

1. Patched cluster and verified the audits for role commands are showing the 
effective user instead of "hive" user.
2. Also verified the DB tables for x_role and x_trxlog tables.
3. Verified all the existing unit tests run successfully.


Thanks,

Sailaja Polavarapu

Reply via email to