----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71366/#review217923 -----------------------------------------------------------
Ship it! Ship It! - Mehul Parikh On Aug. 25, 2019, 4:48 p.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71366/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2019, 4:48 p.m.) > > > Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh > Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2550 > https://issues.apache.org/jira/browse/RANGER-2550 > > > Repository: ranger > > > Description > ------- > > **Problem Statement:** Currently sort_order field length allows only 128 > possible values in mysql db flavor as its data type is tinyint(3). > > In few of the tables its int while in oracle DB Flavor its smallint. > > **Proposed Solution:** > Proposed patch shall change the sort_order field length to int in all the db > flavours schema. > **Note:** > Proposed patch do not change the field length in the upgrade case. > If required, user can increase the field length by executing sql commands in > the DB schema. > > > Diffs > ----- > > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql > 377e61ff2 > security-admin/db/mysql/patches/009-updated_schema.sql 085c50dd7 > security-admin/db/mysql/patches/016-updated-schema-for-tag-based-policy.sql > 86b17bca8 > security-admin/db/mysql/patches/020-datamask-policy.sql 2ec290995 > security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql > bd5c6a499 > security-admin/db/oracle/patches/009-updated_schema.sql 2f0996cf4 > > security-admin/db/oracle/patches/016-updated-schema-for-tag-based-policy.sql > f5b03c149 > security-admin/db/oracle/patches/020-datamask-policy.sql 489fd3a08 > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > 9a863e26b > > security-admin/db/postgres/patches/016-updated-schema-for-tag-based-policy.sql > 59aec9175 > security-admin/db/postgres/patches/020-datamask-policy.sql 79a509b3c > > security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql > 5ec62fb08 > > security-admin/db/sqlanywhere/patches/016-updated-schema-for-tag-based-policy.sql > a1c2f51b0 > security-admin/db/sqlanywhere/patches/020-datamask-policy.sql 3cc044765 > security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql > ee41452da > > security-admin/db/sqlserver/patches/016-updated-schema-for-tag-based-policy.sql > c00bab1f8 > security-admin/db/sqlserver/patches/020-datamask-policy.sql bd658e5fb > security-admin/db/sqlserver/patches/041-create-role-schema.sql a40428111 > > > Diff: https://reviews.apache.org/r/71366/diff/3/ > > > Testing > ------- > > Tested Ranger installation with the patch and can see sort_order field data > type as int. > > > Thanks, > > Pradeep Agrawal > >