----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71651/ -----------------------------------------------------------
(Updated Oct. 23, 2019, 11:41 p.m.) Review request for ranger, Madhan Neethiraj, Sarath Subramanian, and Velmurugan Periasamy. Changes ------- Addressed review comments Bugs: RANGER-2630 https://issues.apache.org/jira/browse/RANGER-2630 Repository: ranger Description ------- Currently, status of Atlas Entity in the delete notification received by TagSync is ACTIVE. Because of this, current implementation of tagsync works as expected. Tagsync should be able to handle delete operaton even if Atlas decides to set the deleted entity's state to something other than ACTIVE. Diffs (updated) ----- tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java a4cab28e8 tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java 9781aa646 Diff: https://reviews.apache.org/r/71651/diff/6/ Changes: https://reviews.apache.org/r/71651/diff/5-6/ Testing ------- Passes all unit tests Thanks, Abhay Kulkarni