----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71668/#review218465 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java Lines 37 (patched) <https://reviews.apache.org/r/71668/#comment306200> "display name '{0}' is already used by service '{1}'" agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java Lines 39 (patched) <https://reviews.apache.org/r/71668/#comment306201> "invalid display name '{0}'. It should be not be longer than 256 characters, should not start with space, and should not include special characters (except underscore, hypen and space)" agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java Lines 41 (patched) <https://reviews.apache.org/r/71668/#comment306202> This error seems same as SERVICE_VALIDATION_ERR_SERVICE_DISPLAY_NAME_CONFICT - except that 'id' is included here. Consider using a single error code for this error condition. agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java Lines 57 (patched) <https://reviews.apache.org/r/71668/#comment306203> - "display name '{0}' is already used by service-def '{1}'" - SERVICE_DEF_VALIDATION_ERR_SERVICE_DEF__DISPLAY_NAME_CONFICT and SERVICE_DEF_VALIDATION_ERR_ID_DISPLAY_NAME_CONFLICT seem duplicates. Consider using a single error code the same error condition. agents-common/src/main/java/org/apache/ranger/plugin/model/RangerService.java Line 87 (original), 88 (patched) <https://reviews.apache.org/r/71668/#comment306204> add: setDisplayName(other.getDisplayName()); - Madhan Neethiraj On Oct. 30, 2019, 5:54 a.m., Kishor Gollapalliwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71668/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2019, 5:54 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan > Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-2590 > https://issues.apache.org/jira/browse/RANGER-2590 > > > Repository: ranger > > > Description > ------- > > Name of service-defs (hdfs/hive/hbase/kafka/..) and services > (test_hive/prod_hive/..) are rendered in Ranger landing page. It will be > helpful to see a more descriptive string in the UI - like Apache Kafka, > Apache HBase, Production Hive, Test Hive. To support this: > > service-def and service should be enhanced with an additional attribute > displayName > UI should be updated to use the value in displayName instead of name > default value of displayName should be the value of name > displayName should be unique - just as name is. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java > 2927362ab > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerService.java > ed8d38417 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java > 50d84a436 > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java > 0954beb82 > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java > f96fcfc92 > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceValidator.java > 9b5d8d511 > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java > 74653b2f7 > > agents-common/src/main/java/org/apache/ranger/plugin/store/ServiceStore.java > ba7407fc4 > agents-common/src/main/resources/service-defs/ranger-servicedef-abfs.json > 18454deff > agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json > 07a980031 > > agents-common/src/main/resources/service-defs/ranger-servicedef-elasticsearch.json > b055bf818 > agents-common/src/main/resources/service-defs/ranger-servicedef-hbase.json > 71fae66d4 > agents-common/src/main/resources/service-defs/ranger-servicedef-hdfs.json > 2e5d07c2f > agents-common/src/main/resources/service-defs/ranger-servicedef-hive.json > 5722e0948 > agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json > 800b12367 > agents-common/src/main/resources/service-defs/ranger-servicedef-kms.json > f96cb9cd1 > agents-common/src/main/resources/service-defs/ranger-servicedef-knox.json > 495a69913 > agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json > a6e76a01c > > agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json > 8235edc3d > agents-common/src/main/resources/service-defs/ranger-servicedef-nifi.json > 5f1e46f09 > agents-common/src/main/resources/service-defs/ranger-servicedef-ozone.json > 5787d93d6 > agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json > 151c7d2fa > agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json > 2f12721e1 > agents-common/src/main/resources/service-defs/ranger-servicedef-sqoop.json > 8cff9abdd > agents-common/src/main/resources/service-defs/ranger-servicedef-storm.json > 03c1574ff > agents-common/src/main/resources/service-defs/ranger-servicedef-tag.json > c17b75070 > agents-common/src/main/resources/service-defs/ranger-servicedef-wasb.json > 946b662ad > agents-common/src/main/resources/service-defs/ranger-servicedef-yarn.json > a32c08d93 > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceValidator.java > c271dd955 > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql > 1857a77e9 > > security-admin/db/mysql/patches/044-add-displayName-col-in-x_service_def_and_x_service.sql > PRE-CREATION > security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql > 0293abeaa > > security-admin/db/oracle/patches/044-add-displayName-col-in-x_service_def_and_x_service.sql > PRE-CREATION > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > 1d1a31c51 > > security-admin/db/postgres/patches/044-add-displayName-col-in-x_service_def_and_x_service.sql > PRE-CREATION > > security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql > 5381398da > > security-admin/db/sqlanywhere/patches/044-add-displayName-col-in-x_service_def_and_x_service.sql > PRE-CREATION > security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql > d24de6863 > > security-admin/db/sqlserver/patches/044-add-displayName-col-in-x_service_def_and_x_service.sql > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > ec44aa16e > security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java > 0791f2f54 > security-admin/src/main/java/org/apache/ranger/db/XXServiceDefDao.java > beef5bf49 > security-admin/src/main/java/org/apache/ranger/entity/XXServiceBase.java > 366dc5567 > security-admin/src/main/java/org/apache/ranger/entity/XXServiceDefBase.java > 9a353599a > > security-admin/src/main/java/org/apache/ranger/patch/PatchForXServiceUpdate_J10031.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > d60b73809 > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java > 9b543ef8d > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceServiceBase.java > 7db67ac13 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 6cc479991 > security-admin/src/main/webapp/scripts/models/RangerServiceDef.js 398941abd > > security-admin/src/main/webapp/scripts/views/service/RangerServiceViewDetail.js > a169baa7c > security-admin/src/main/webapp/scripts/views/service/ServiceForm.js > b7215f2c1 > > security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html > 82b667ccf > security-admin/src/main/webapp/templates/helpers/XAHelpers.js 4b64d01b5 > > security-admin/src/main/webapp/templates/service/RangerServiceViewDetail_tmpl.html > d9fe51f1b > security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java > f687ab8bc > > > Diff: https://reviews.apache.org/r/71668/diff/2/ > > > Testing > ------- > > Build succeeded on apache master > Run setup using above build > Validated following scenarios for ranger-admin > Service : > Create with empty displayName, displayName = name > Create with valid displayName, displayName = displayName > Create with existing displayName, creation failed > Update with empty displayName, displayName = name > Update with valid displayName, displayName = displayName > Update both name and displayName, both updated succcessfully. > Update with existing displayName, update failed > > ServiceDef : > Create with empty displayName, displayName = name > Create with valid displayName, displayName = displayName > Update with empty displayName, displayName = name > Update with valid displayName, displayName = displayName > Update both name and displayName, both updated succcessfully. > > > Thanks, > > Kishor Gollapalliwar > >
