-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71802/
-----------------------------------------------------------
(Updated Nov. 22, 2019, 2:56 a.m.)
Review request for ranger, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu,
and Velmurugan Periasamy.
Changes
-------
Addressed review comments
Bugs: RANGER-2652
https://issues.apache.org/jira/browse/RANGER-2652
Repository: ranger
Description
-------
- Encapsulate Ranger policy evaluators into a class (PolicyEngine)
- Separate Ranger Policy Engine APIs based on their users (plugin or
ranger-admin), and define corresponding wrapper interfaces (RangerPolicyEngine
and RangerServicePoliciesAdmin). Provide their respective implementation
classes.
- Remove unused functionality (keeping usage-counts, re-ordering
policy-evaluators based on their usage, etc.)
- Separate out request preprocessing into a separate interface
(RangerAccessRequestProcessor) which wraps context-enrichers and roles for
pre-processing/enriching access request.
- Optimize Trie for incremental changes (adds/deletes)
- Assorted code clean-up.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java
6a12d6338
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEngine.java
PRE-CREATION
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestProcessor.java
PRE-CREATION
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java
72628eaf6
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineCache.java
33152e608
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineCacheForEngineOptions.java
11450ae57
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
7c48ef763
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
68f779121
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerTagResource.java
922f67d7b
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java
fd20d634e
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java
4512a5e75
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContext.java
661110440
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
fbed32c66
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerDefaultRequestProcessor.java
PRE-CREATION
agents-common/src/main/java/org/apache/ranger/plugin/store/ServiceStore.java
67778ef9c
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java
ccd51cb09
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRolesUtil.java
c96d25079
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyACLs.java
8846ee8ec
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyDb.java
67c02b20a
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
6a160c9cf
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngineComparison.java
b0a12c341
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestRangerAuthContext.java
061b39222
agents-common/src/test/resources/policyengine/test_policydb_hdfs.json
agents-common/src/test/resources/policyengine/test_policydb_hive.json
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
a27c43d68
hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/TestPolicyEngine.java
cda80f897
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
c077ce3b7
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
1e1593d29
ranger-tools/src/main/java/org/apache/ranger/policyengine/CommandLineParser.java
fe9ec179b
ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java
8af378d90
ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestOptions.java
1486f52d8
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerPolicyenginePerfTester.java
2da4397d3
ranger-tools/src/test/java/org/apache/ranger/policyengine/RangerPolicyEnginePerformanceTest.java
86909fd10
security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdmin.java
PRE-CREATION
security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminImpl.java
PRE-CREATION
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
85289dd71
security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java
68740f50d
security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 4c501e4c4
security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java d667f2c46
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
54c9ee340
security-admin/src/main/resources/META-INF/jpa_named_queries.xml e36f56322
security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java
422cdbec6
security-admin/src/test/resources/admin/service-defs/test-hbase-servicedef.json
PRE-CREATION
security-admin/src/test/resources/admin/service-defs/test-hdfs-servicedef.json
PRE-CREATION
security-admin/src/test/resources/admin/service-defs/test-hive-servicedef.json
PRE-CREATION
security-admin/src/test/resources/admin/service-defs/test-tag-servicedef.json
PRE-CREATION
Diff: https://reviews.apache.org/r/71802/diff/2/
Changes: https://reviews.apache.org/r/71802/diff/1-2/
Testing
-------
Passes all unit tests
Thanks,
Abhay Kulkarni
