> On Nov. 27, 2019, 7:20 p.m., Abhay Kulkarni wrote: > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > > Line 1158 (original), 1161 (patched) > > <https://reviews.apache.org/r/71839/diff/1/?file=2179621#file2179621line1161> > > > > When objectType is DATABASE, isn't objectName the same as dbName?
ObjectName is always the table name, without dbName there filter is not working as it null. - Ramesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71839/#review218828 ----------------------------------------------------------- On Nov. 27, 2019, 5:53 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71839/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2019, 5:53 p.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, > Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2656 > https://issues.apache.org/jira/browse/RANGER-2656 > > > Repository: ranger > > > Description > ------- > > RANGER-2656:RangerHiveAuthorizer filterListCmdObjects failed to filter > database / tables when HMS calls the authorizer for filtering > > > Diffs > ----- > > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > b80f1bd > > > Diff: https://reviews.apache.org/r/71839/diff/1/ > > > Testing > ------- > > Verified in Local VM. > 1) Show database and Show table via spark shell to invoke HMS api works as > expected. > > > Thanks, > > Ramesh Mani > >
