-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71891/#review218971
-----------------------------------------------------------


Ship it!




Ship It!

- Abhay Kulkarni


On Dec. 7, 2019, 1:55 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71891/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2019, 1:55 a.m.)
> 
> 
> Review request for ranger and Abhay Kulkarni.
> 
> 
> Bugs: RANGER-2654
>     https://issues.apache.org/jira/browse/RANGER-2654
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> - updated RangerAdminTagRetriever to use pluginConfig from RangerBasePlugin
> - replaced multiple instances of RangerAdminConfig, to avoid repeated loading 
> of configuration files
> 
> 
> Diffs
> -----
> 
>   
> agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerAdminConfig.java
>  8783142a6 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java
>  99d97cc4a 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAdminTagRetriever.java
>  e4b19c367 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
>  7e0369023 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagRetriever.java
>  91fdcc3c1 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
>  f5cdddf83 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java
>  01a7c9f77 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java
>  3b549608c 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
>  543d13f80 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 
> 3761ef2ce 
>   security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 
> ec4615d94 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> 80e3f978f 
>   security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java 
> 2d7f40745 
>   
> security-admin/src/main/java/org/apache/ranger/common/RangerAdminTagEnricher.java
>  c4b134e53 
>   security-admin/src/main/java/org/apache/ranger/common/RangerRoleCache.java 
> 0b94c1954 
>   
> security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java
>  536cb0613 
>   
> security-admin/src/main/java/org/apache/ranger/common/RangerServiceTagsCache.java
>  249a3bfab 
>   security-admin/src/main/java/org/apache/ranger/patch/BaseLoader.java 
> 6cae5cba2 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
> 5a57ee0e1 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefService.java
>  1ec2f495b 
> 
> 
> Diff: https://reviews.apache.org/r/71891/diff/1/
> 
> 
> Testing
> -------
> 
> - manually verified that RangerAdminTagRetriever successfully downloads tags
> - verified that all unit tests pass
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Reply via email to