----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71893/#review219014 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java Line 1638 (original), 1638 (patched) <https://reviews.apache.org/r/71893/#comment307036> Is it necessary to disallow association of KMS-service with a tag-service? I think not automatically linking KMS services with a tag-service should be good enough. Please review. - Madhan Neethiraj On Dec. 11, 2019, 11:07 a.m., Dhaval Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71893/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2019, 11:07 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan > Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, and Pradeep Agrawal. > > > Bugs: RANGER-2668 > https://issues.apache.org/jira/browse/RANGER-2668 > > > Repository: ranger > > > Description > ------- > > Ranger KMS shouldn't be having Tag based service hence, > 1.) No Tag based service will be associated with RangerKMS default service. > 2.) User should not be able to associate tag service while creating and > updating RangerKMS service. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 0fd5093 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > f2bbd3c > > security-admin/src/main/webapp/scripts/views/service/RangerServiceViewDetail.js > a79513b > security-admin/src/main/webapp/scripts/views/service/ServiceForm.js 653d3d5 > > security-admin/src/main/webapp/templates/service/RangerServiceViewDetail_tmpl.html > 978d785 > > > Diff: https://reviews.apache.org/r/71893/diff/3/ > > > Testing > ------- > > 1.) Tag service is not associated with auto generated RangerKMS service and > Default service. > 2.) User is not be able to associate tag service while creating and updating > RangerKMS service. > > > Thanks, > > Dhaval Shah > >
