----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72000/#review219316 -----------------------------------------------------------
plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaClient.java Line 91 (original), 89 (patched) <https://reviews.apache.org/r/72000/#comment307466> Please review and fix formatting. plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaClient.java Lines 102 (patched) <https://reviews.apache.org/r/72000/#comment307467> Please consider logging the exception with LOG.error() - Abhay Kulkarni On Jan. 15, 2020, 6:09 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72000/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2020, 6:09 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, > Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2702 > https://issues.apache.org/jira/browse/RANGER-2702 > > > Repository: ranger > > > Description > ------- > > RANGER-2702:Upgrade Kafka Version in Ranger to 2.4 > > > Diffs > ----- > > > plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaClient.java > 6929257 > > plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaConnectionMgr.java > 9e0d6b4 > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerGSSTest.java > 43e88b5 > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerSASLSSLTest.java > 88a3e02 > > plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java > 8d2f0a4 > pom.xml f53c54d > > > Diff: https://reviews.apache.org/r/72000/diff/1/ > > > Testing > ------- > > Testing done in local vm > > > Thanks, > > Ramesh Mani > >
