> On Jan. 29, 2020, 11:55 a.m., Pradeep Agrawal wrote:
> > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js
> > Line 1937 (original), 2061 (patched)
> > <https://reviews.apache.org/r/72001/diff/4/?file=2209934#file2209934line2069>
> >
> >     what is 36e5 ?

The subtraction returns the difference between the two dates in milliseconds. 
36e5 is the scientific notation for 60*60*1000, dividing by which converts the 
milliseconds difference into hours.


- Nitin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72001/#review219413
-----------------------------------------------------------


On Jan. 29, 2020, 11:45 a.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72001/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2020, 11:45 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, 
> Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2670
>     https://issues.apache.org/jira/browse/RANGER-2670
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> 1) Bookmark functionality for Report and Encryption tab.
> 2) Audit tab :
>  * sortBy and sortOrder are in query-params (All Tab).
>  * plugin-status page to highlight the plugins not having the latest policies.
>  * clicking on an audit entry to show a pop-up with audit log details.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 037c591 
>   security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 
> 38884c7 
>   security-admin/src/main/webapp/scripts/collection_bases/VXTrxLogListBase.js 
> 8e24b71 
>   security-admin/src/main/webapp/scripts/collections/XABaseCollection.js 
> 8b7a68d 
>   security-admin/src/main/webapp/scripts/controllers/Controller.js 99b69a4 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> a559248 
>   security-admin/src/main/webapp/scripts/routers/Router.js 14f4916 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 5ec258f 
>   security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js 4954b74 
>   
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js
>  798fe79 
>   
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js
>  4ee9487 
>   
> security-admin/src/main/webapp/scripts/views/reports/AuditAccessLogDetailView.js
>  PRE-CREATION 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 7345f5a 
>   security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 
> 5672552 
>   security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 
> d1f421f 
>   security-admin/src/main/webapp/styles/xa.css f75facb 
>   
> security-admin/src/main/webapp/templates/reports/AuditAccessLogDetail_tmpl.html
>  PRE-CREATION 
>   security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html 
> befb230 
> 
> 
> Diff: https://reviews.apache.org/r/72001/diff/5/
> 
> 
> Testing
> -------
> 
> 1.Checked bookmark functionality is working for unzone and zone policy 
> listing page.
> 2.Checked bookmark functionality is working for audit page.
> 3.Checked bookmark functionality is working for user/role listing page.
> 4.Checked bookmark functionality is working for permission page.
> 
> In this patch, two new functionality added.
> 1) In Audit ==>> Access tab
>  => When we click on policy ID column its open Policy details popup.
>  => When we click other than policy ID column its open Access log details 
> popup.
> 
> 2) In Audit ==>> Plugin Status
>   Highlight policy/tag download/active cells when they are behind the ‘Last 
> Update’ time.
>   => Red: If ‘Last Update’ >= 2min of download/active in 
> Policy(Time)/tag(Time) details.
>   => Yellow: If ‘Last Update’ < 2min of download/active in 
> Policy(Time)/tag(Time) details.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>

Reply via email to