----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72194/#review219777 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On March 4, 2020, 3:47 p.m., Grant Henke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72194/ > ----------------------------------------------------------- > > (Updated March 4, 2020, 3:47 p.m.) > > > Review request for ranger and Pradeep Agrawal. > > > Bugs: RANGER-2749 > https://issues.apache.org/jira/browse/RANGER-2749 > > > Repository: ranger > > > Description > ------- > > agents-common uses commons-lang but does not specify it in the > pom. Depending on a transitive dependncy is not safe. > > This patch adds the explicit dependency to the pom. > > > Diffs > ----- > > agents-common/pom.xml c78dc5fc2 > > > Diff: https://reviews.apache.org/r/72194/diff/1/ > > > Testing > ------- > > I verified this fixes the issue I saw when running an external/custom plugin > with hadoop-commons 3.2+. > > Before this fix I saw: > java.lang.NoClassDefFoundError: org/apache/commons/lang/StringUtils > at > org.apache.ranger.plugin.policyengine.RangerAccessRequestImpl.setAccessType(RangerAccessRequestImpl.java:160) > at > org.apache.ranger.plugin.policyengine.RangerAccessRequestImpl.<init>(RangerAccessRequestImpl.java:63) > at > org.apache.ranger.plugin.policyengine.RangerAccessRequestImpl.<init>(RangerAccessRequestImpl.java:58) > > > Thanks, > > Grant Henke > >
