> On March 10, 2020, 5:04 a.m., Pradeep Agrawal wrote: > > security-admin/src/main/resources/META-INF/jpa_named_queries.xml > > Lines 133 (patched) > > <https://reviews.apache.org/r/72219/diff/1/?file=2213322#file2213322line133> > > > > WHERE user.id=groupUser.userId and group.id=groupUser.parentGroupId > > could be faster
Changes made as suggested. Please review the new changes. - Sailaja ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72219/#review219857 ----------------------------------------------------------- On March 11, 2020, 6:52 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72219/ > ----------------------------------------------------------- > > (Updated March 11, 2020, 6:52 p.m.) > > > Review request for ranger, Abhay Kulkarni, Ramesh Mani, and Velmurugan > Periasamy. > > > Bugs: RANGER-2753 > https://issues.apache.org/jira/browse/RANGER-2753 > > > Repository: ranger > > > Description > ------- > > Added DB query to retrive user group mappings from x_user, x_group, and > x_group_users tables. This will eliminate multiple calls to database while > populating user store information. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerUserStore.java > dfe742f96 > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 88a4330f1 > > security-admin/src/main/java/org/apache/ranger/common/RangerUserStoreCache.java > 8ffc98cc7 > security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java cea90c165 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml f23bf2e65 > > > Diff: https://reviews.apache.org/r/72219/diff/2/ > > > Testing > ------- > > Verified all the unit tests are passed. > Also verified functionality with more no. of entries in users and group and > mappings tables. > > > Thanks, > > Sailaja Polavarapu > >
