----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72261/#review220060 -----------------------------------------------------------
ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java Lines 307 (patched) <https://reviews.apache.org/r/72261/#comment308334> Consider having block, #305 - #308, inside 'if (LOG.isDebugEnabled()) {' - since this block only has debug statement. Also, please review other use of LOG.debug() and surround them with 'if (LOG.isDebugEnabled()) {' - to minimize performance impact of string concat in debug statements. - Madhan Neethiraj On March 24, 2020, 1:15 a.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72261/ > ----------------------------------------------------------- > > (Updated March 24, 2020, 1:15 a.m.) > > > Review request for ranger, Abhay Kulkarni, Mehul Parikh, Mugdha Varadkar, > Ramesh Mani, and Velmurugan Periasamy. > > > Bugs: RANGER-2705 > https://issues.apache.org/jira/browse/RANGER-2705 > > > Repository: ranger > > > Description > ------- > > Made code changes for both incremental and full sync to use JNDI APIs > (LdapName and Rdn) to retrieve user/group name from the DN. Also, added few > null checks while updating user/group information to ranger admin. > > > Diffs > ----- > > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java > 0c54f71b3 > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java > 31b4d3d67 > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java > 9563eee8d > > > Diff: https://reviews.apache.org/r/72261/diff/1/ > > > Testing > ------- > > 1. Verified all the existing unit tests are run successfully. > 2. Patched a cluster with my changes and verified both with Active directory > and free IPA as the DN for users are in differnt formats. > > > Thanks, > > Sailaja Polavarapu > >
