> On March 19, 2020, 7:34 p.m., Ramesh Mani wrote: > > hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HbaseAuthUtilsImplTest.java > > Lines 32 (patched) > > <https://reviews.apache.org/r/72247/diff/1/?file=2214237#file2214237line32> > > > > Should this be checked only if the flag for exec permission check is > > true? > > Could you please create a test case for this scenairo?
Here just verifying the static veriable defined for execute when action exec is passed. Cannot validate execute permission based on the configuration in this test case. We can validate the same in HBaseRangerAuthorizationTest but the test cases ignored at this moment because HBase 2.0.2 is not compatible with Hadoop 3.1.4(RANGER-2432). What do you think of another JIRA for adding the test case and fixing the test cases with incompatibilty issue as well? - Rajeshbabu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72247/#review220017 ----------------------------------------------------------- On March 19, 2020, 10:10 a.m., Rajeshbabu Chintaguntla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72247/ > ----------------------------------------------------------- > > (Updated March 19, 2020, 10:10 a.m.) > > > Review request for ranger and Ramesh Mani. > > > Repository: ranger > > > Description > ------- > > - added execute permission to HBase service def > - Added java patch file to support execute permission > - Made changes in Ranger coprocessor to check for exec permission in > endpoint coporcessor hook. > > > Diffs > ----- > > agents-common/src/main/resources/service-defs/ranger-servicedef-hbase.json > f98c919a1 > > hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/HbaseAuthUtils.java > f8ee168d7 > > hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/HbaseAuthUtilsImpl.java > c2e1e7753 > > hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java > 952ef61dc > > hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HbaseAuthUtilsImplTest.java > 1b8edd437 > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql > 47618f6b3 > security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql > e59e7de61 > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > 37ea61912 > > security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql > bd1c47cc4 > security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql > 22e1746f2 > > security-admin/src/main/java/org/apache/ranger/patch/PatchForHBaseServiceDefUpdate_J10034.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/72247/diff/1/ > > > Testing > ------- > > Tested in the cluster and ranger admin is showing the execute to select along > with create,read,write and admin. Verified policy creation by providing the > execute permission for an user and listed the policy it's displaying properly. > > > Thanks, > > Rajeshbabu Chintaguntla > >
