----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72325/#review220280 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java Line 880 (original), 999 (patched) <https://reviews.apache.org/r/72325/#comment308614> if this is not required, the please remove it. - Pradeep Agrawal On April 9, 2020, 1:25 p.m., Dineshkumar Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72325/ > ----------------------------------------------------------- > > (Updated April 9, 2020, 1:25 p.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Kishor Gollapalliwar, > Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Vishal Suvagia, and Velmurugan > Periasamy. > > > Repository: ranger > > > Description > ------- > > Handling the scenario when non-existing policy send with mergeIfExist=true > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 38b49820b > security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java > d85028c95 > > > Diff: https://reviews.apache.org/r/72325/diff/3/ > > > Testing > ------- > > Test case: > > Creating non-existing policy with below param > a) mergeIfExists=true > b) serviceName > c) policyName > > Expected: New policy should be created. > > Creating policy with below param and role which is already exist > a) mergeIfExists=true > b) serviceName > c) policyName > > Expected: role should get merged. > > Creating policy with below param and policy condition in kafka service which > is already exist > a) mergeIfExists=true > b) serviceName > c) policyName > > Expected: condition should get merged. > > > Thanks, > > Dineshkumar Yadav > >
