----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72366/#review220386 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java Lines 97 (patched) <https://reviews.apache.org/r/72366/#comment308745> 1) if possible replace !isEmpty() with isNotEmpty() methods. 2) write "name".equals(name) 3) there should be a space after "if". like line 93 - Pradeep Agrawal On April 20, 2020, 10:35 a.m., Mahesh Bandal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72366/ > ----------------------------------------------------------- > > (Updated April 20, 2020, 10:35 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Madhan Neethiraj, > Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and > Velmurugan Periasamy. > > > Bugs: RANGER-2794 > https://issues.apache.org/jira/browse/RANGER-2794 > > > Repository: ranger > > > Description > ------- > > This issue occurs when we try to search roles by User Name or Group Name. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java > 98a8596c8 > > security-admin/src/main/java/org/apache/ranger/service/RangerRoleServiceBase.java > 5b22a5361 > > > Diff: https://reviews.apache.org/r/72366/diff/2/ > > > Testing > ------- > > Searched for roles by applying filter such as 'User Name', 'Group Name', > 'Role Name'. Search shows expected output. > > > Thanks, > > Mahesh Bandal > >
