> On May 15, 2020, 2:43 p.m., Madhan Neethiraj wrote: > > agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json > > Lines 164 (patched) > > <https://reviews.apache.org/r/72513/diff/1/?file=2231715#file2231715line164> > > > > Changes in service-def (like addition of resources/access-types, > > changes in access-types/data-mask/row-filter) will not be applied to > > existing service-def in Ranger. Updating existing service-def would require > > a Java patch. Please file a JIRA to track Java patch to handle this.
RANGER-2795 is tracking this > On May 15, 2020, 2:43 p.m., Madhan Neethiraj wrote: > > agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json > > Lines 266 (patched) > > <https://reviews.apache.org/r/72513/diff/1/?file=2231715#file2231715line266> > > > > I suggest to not change itemId of existing entries; and assign > > itemId=13 for the new entry 'execute'. Sure. Is itemid used anywhere? > On May 15, 2020, 2:43 p.m., Madhan Neethiraj wrote: > > plugin-presto/src/test/resources/presto-policies.json > > Line 1013 (original), 1187 (patched) > > <https://reviews.apache.org/r/72513/diff/1/?file=2231718#file2231718line1187> > > > > Row-filter expressions are likely to refer to columns in the table for > > which the filter is applied. When wildcard is allowed in row-filter > > policies, it might be challenging to make sure that the row-filter > > expression is valid for all the tables covered by the wildcard. When the > > row-filter is invalid for a table, the query will fail. Hence wildCard was > > disabled for row-filters. Please review to make sure that this is clearly > > understood. I understand your point, however, this is already in the master, you are commenting on an update to the test policies which are a reflection of what is currently in master. - Bolke ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72513/#review220783 ----------------------------------------------------------- On May 17, 2020, 7:38 a.m., Bolke de Bruin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72513/ > ----------------------------------------------------------- > > (Updated May 17, 2020, 7:38 a.m.) > > > Review request for ranger, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, > and Ramesh Mani. > > > Bugs: https://jira.apache.org/jira/browse/RANGER-2826 > > https://issues.apache.org/jira/browse/https://jira.apache.org/jira/browse/RANGER-2826 > > > Repository: ranger > > > Description > ------- > > Presto 332/333 are backwards incompatible. > > > Diffs > ----- > > agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json > 4d5b79582 > > plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java > d4521a392 > > plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlTest.java > c00d51986 > plugin-presto/src/test/resources/presto-policies.json 28eabf2d6 > pom.xml ebce7c9f0 > > ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java > bfb3a5961 > > security-admin/src/main/java/org/apache/ranger/patch/PatchForPrestoToSupportPresto333_J10037.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/72513/diff/2/ > > > Testing > ------- > > Unit tests updated. Production. > > > Thanks, > > Bolke de Bruin > >
