----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72346/#review220854 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java Lines 69 (patched) <https://reviews.apache.org/r/72346/#comment309575> Consider using BaseDao.getAll(), instead of introducing this method; named query 'XXGroupUser.findAllXXGroupUser' will not be needed with this change. security-admin/src/main/java/org/apache/ranger/entity/XXUser.java Lines 290 (patched) <https://reviews.apache.org/r/72346/#comment309574> For simplicity, consider using Objects.hash(), as below: return Objects.hash(super.hashCode(), name, description, status, credStoreId); security-admin/src/main/java/org/apache/ranger/view/VXUser.java Lines 315 (patched) <https://reviews.apache.org/r/72346/#comment309577> For simplicity, consider using Objects.equals(), like below: return Objects.equals(status, vxUser.status) && Objects.equals(name, vxUser.name) && Objects.equals(description, vxUser.description) && Objects.equals(credStoreId, vxUser.credStoreId); security-admin/src/main/java/org/apache/ranger/view/VXUser.java Lines 323 (patched) <https://reviews.apache.org/r/72346/#comment309576> For simplicity, consider using Objects.hash(), like below: return Objects.hash(super.hashCode(), name, description, credStoreId, status); - Madhan Neethiraj On April 10, 2020, 11:47 a.m., Haoxiang Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72346/ > ----------------------------------------------------------- > > (Updated April 10, 2020, 11:47 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-2789 > https://issues.apache.org/jira/browse/RANGER-2789 > > > Repository: ranger > > > Description > ------- > > GET API service/xusers/users turns very slow when there are more than 1000 > users > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java > 1e41e708a > security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 0464e7b6e > security-admin/src/main/java/org/apache/ranger/service/XUserService.java > 6ff8823da > > security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java > 9cdc14ebf > security-admin/src/main/java/org/apache/ranger/view/VXUser.java 96f6468f7 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 22e71e549 > > > Diff: https://reviews.apache.org/r/72346/diff/1/ > > > Testing > ------- > > 1.Compilation OK > 2.Already used in production environment > > > Thanks, > > Haoxiang Ma > >
