----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73027/#review222224 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java Lines 29 (patched) <https://reviews.apache.org/r/73027/#comment311273> Could you please address the PMD violations? [INFO] --- maven-pmd-plugin:3.7:check (default) @ security-admin-web --- [INFO] PMD Failure: org/apache/ranger/common/PropertiesUtil.java:29 Rule:UnusedImports Priority:4 Avoid unused imports such as 'java.sql.Driver'. [INFO] PMD Failure: org/apache/ranger/common/PropertiesUtil.java:30 Rule:UnusedImports Priority:4 Avoid unused imports such as 'java.sql.DriverManager'. [INFO] PMD Failure: org/apache/ranger/common/PropertiesUtil.java:31 Rule:UnusedImports Priority:4 Avoid unused imports such as 'java.sql.DriverPropertyInfo'. [INFO] PMD Failure: org/apache/ranger/common/PropertiesUtil.java:32 Rule:UnusedImports Priority:4 Avoid unused imports such as 'java.sql.SQLException'. [INFO] PMD Failure: org/apache/ranger/common/PropertiesUtil.java:40 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.commons.collections.ListUtils'. [INFO] PMD Failure: org/apache/ranger/common/PropertiesUtil.java:42 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.commons.lang3.ArrayUtils'. [INFO] ------------------------------------------------------------------------ - Velmurugan Periasamy On Nov. 21, 2020, 1:37 p.m., Mahesh Bandal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73027/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2020, 1:37 p.m.) > > > Review request for ranger, Ankita Sinha, Dineshkumar Yadav, Jayendra Parab, > Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Mugdha > Varadkar, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan > Periasamy. > > > Bugs: RANGER-3084 > https://issues.apache.org/jira/browse/RANGER-3084 > > > Repository: ranger > > > Description > ------- > > Ranger database connection fails when postgres is SSL enabled & > postgresql-42.2.x driver jar is used > > > Diffs > ----- > > kms/config/kms-webapp/dbks-site.xml 6990fb74c > kms/scripts/db_setup.py 9928f462f > kms/scripts/install.properties 814edb306 > kms/scripts/setup.sh 9b4df3875 > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSDB.java 8b9bf4bb1 > security-admin/scripts/db_setup.py b448738d1 > security-admin/scripts/install.properties a18bcd5b3 > security-admin/scripts/setup.sh 696d0c9bd > security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java > 43bbdfb35 > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > fcd4bd0ee > > > Diff: https://reviews.apache.org/r/73027/diff/2/ > > > Testing > ------- > > Tested with postgresql-42.2.14.jre7.jar in ssl enabled postgres environment. > > > Thanks, > > Mahesh Bandal > >
