----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73407/#review223124 -----------------------------------------------------------
Ship it! - Madhan Neethiraj On June 8, 2021, 2:40 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73407/ > ----------------------------------------------------------- > > (Updated June 8, 2021, 2:40 p.m.) > > > Review request for ranger, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, > and Velmurugan Periasamy. > > > Bugs: RANGER-3309 > https://issues.apache.org/jira/browse/RANGER-3309 > > > Repository: ranger > > > Description > ------- > > Currently, tagsync uploads tags received through Kafka events to Ranger one > event at a time. Batched upload of tags will help in improving performance of > tag ingress into Ranger. > > This patch adds support for a env variable to specify the maximum size of > events that can be uploaded in one interaction with Ranger; viz. > 'ranger.tagsync.dest.ranger.max.batch.size' which defaults to value 1. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/rest/ServiceTagsProcessor.java > 67ae77926 > > security-admin/src/main/java/org/apache/ranger/service/RangerTagService.java > 5fdefe5a3 > > tagsync/src/main/java/org/apache/ranger/tagsync/model/AbstractTagSource.java > da4c5cbd3 > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java > 9245fdfc9 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java > ed4ba1704 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java > 21a22cdc5 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java > 8b12affe2 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/file/FileTagSource.java > 62a5f7382 > tagsync/src/main/resources/ranger-tagsync-default.xml 1034bc6e5 > > > Diff: https://reviews.apache.org/r/73407/diff/1/ > > > Testing > ------- > > Passes all unit tests. > > > Thanks, > > Abhay Kulkarni > >
