----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73541/#review223409 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java Lines 429 (patched) <https://reviews.apache.org/r/73541/#comment312477> Consider handling NullPointerException, as httpRequest.getSession(false) will return null if it didn't find any. - Kishor Gollapalliwar On Aug. 24, 2021, 2:20 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73541/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2021, 2:20 p.m.) > > > Review request for ranger, Kishor Gollapalliwar, Mehul Parikh, Ramesh Mani, > Vishal Suvagia, and Velmurugan Periasamy. > > > Bugs: RANGER-3363 > https://issues.apache.org/jira/browse/RANGER-3363 > > > Repository: ranger > > > Description > ------- > > Added support in ranger admin for handling session timeout requests with knox > proxy. When ranger recieves timeout request for an existing session, the > session will be removed and request will be redirected to logout page. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/rest/UserREST.java ffdf1019a > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java > 3e56d9fdf > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java > 9877e14c3 > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java > 6d3599110 > security-admin/src/main/java/org/apache/ranger/util/RestUtil.java 4d7388fe1 > security-admin/src/main/java/org/apache/ranger/view/VXPortalUser.java > 5a1b203ff > > > Diff: https://reviews.apache.org/r/73541/diff/1/ > > > Testing > ------- > > 1. Patched a cluster and verfied the timeout requests are handled as required > with knox proxy case. > > > Thanks, > > Sailaja Polavarapu > >