-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73557/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-3386
https://issues.apache.org/jira/browse/RANGER-3386
Repository: ranger
Description
-------
org.apache.commons.collections.CollectionUtils' performance is too poor and
reduce the performance of ranger plugins, particularly with hdfs. There are too
much places used CollectionUtils.isNotEmpty and CollectionUtils.isEmpty, and we
should replace them.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/authorization/utils/JsonUtils.java
74555eefd
agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java
6b6e91dec
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerAccessedFromClusterCondition.java
e5cc91680
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerAccessedFromClusterTypeCondition.java
50a92bd6f
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerAccessedNotFromClusterCondition.java
d8e966c3d
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerAccessedNotFromClusterTypeCondition.java
eb6c45c0d
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerContextAttributeValueInCondition.java
316cdb5d1
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerContextAttributeValueNotInCondition.java
7df73dfd2
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerHiveResourcesAccessedTogetherCondition.java
960efbe87
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerHiveResourcesNotAccessedTogetherCondition.java
fb2ba2ea9
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerIpMatcher.java
03d09a4ef
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java
5b6653901
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java
0c078a845
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptTemplateConditionEvaluator.java
e88592047
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsAllPresentConditionEvaluator.java
8616c6660
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTimeOfDayMatcher.java
aa8f9c670
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
fbf0360d7
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagForEval.java
3f0db31ac
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java
31156f705
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyResourceSignature.java
2bb65891a
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java
a85410782
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerSecurityZoneValidator.java
35e3ebb91
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java
0954beb82
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java
f96fcfc92
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java
f31483e97
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java
3bfdf9396
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestImpl.java
2a28f701a
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceReadOnly.java
30abf91cc
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineCache.java
015ca097a
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
daa62f408
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
3a954f341
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java
4d6962fff
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyItemEvaluator.java
0f09952f7
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerCustomConditionEvaluator.java
cc250b537
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
c67589c1f
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyItemEvaluator.java
5bbbecedb
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerOptimizedPolicyEvaluator.java
00c0d42ed
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java
4512a5e75
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerValidityScheduleEvaluator.java
6715e2b18
agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java
633ec96ac
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java
8f6facda5
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java
9cf31a2cb
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerURLResourceMatcher.java
40f3df98f
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerAuthContext.java
02f343196
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
8d89a187c
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java
8d4e16fc4
agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractPredicateUtil.java
85fa21383
agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java
82c769f3f
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
c7ea948c9
agents-common/src/main/java/org/apache/ranger/plugin/store/TagValidator.java
c334e3963
agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java
28163698d
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java
c8276f127
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPolicyDeltaUtil.java
9c50f8a33
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRequestedResources.java
a5107b367
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java
605a74ae4
agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java
e91fbff8b
agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java
678e72f1a
agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerSimpleMatcher.java
fc19ed77d
agents-common/src/test/java/org/apache/ranger/plugin/model/validation/ValidationTestUtils.java
a6ca4feb5
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
d1e0c235d
Diff: https://reviews.apache.org/r/73557/diff/1/
Testing
-------
Thanks,
cao zhiqiang
